[formulator-dev] Form.manage_renameObject still needed ?

[Clemens Robbenhaar]

Martijn Faassen writes:
 > Clemens Robbenhaar wrote:
 > > Hi,
 > > 
 > >  I just run into an implementation for "manage_renameObject" in the
 > > ZMIForm which talks about Zope2.4.x having broken semantic for this
 > > rename, making the implementation necessary there.
 > > 
 > >  Can anyone remember what has been the issue which made the current
 > > implementation necessary? 
[...]
 > 
 > Hmm..I would need to research what the issue was again. I recall there 
 > was some change in some version of Zope that suddenly called two methods 
 > in a different order, making what I was doing impossible... Now what was 
 > it again that was made impossible? :)

 I just compared against the implementation in
lib/python/OFS/CopySupport.py, and the only difference (beside of some
error message) is an additional check in CopySupport which looks like:

        if ob.wl_isLocked():
            raise ResourceLockedError, 'Object "%s" is locked via WebDAV' % ob.getId()


 where "ob" is the object to be renamed. I do not think this is one has
been the cause of the problem, thus it looks like the manual
"manage_renameObject" is no longer necessary.

 Any objections to drop it? (Maybe after the next release, if the
changes to the last release are considered big enoght anyway?)

Cheers,
Clemens