[silva-dev] request.model in public layout

Andy Altepeter aaltepet at bethel.edu
Tue Apr 4 17:22:36 CEST 2006


> > What I don't understand, though, is why an explicit delete is required
> > _only_ for the public layout?  Shouldn't the potential memory leak happen
> > in other views as well?
>
> You're right, the edit views have the same problem.
>
> Solving that is quite an undertaking though (but maybe the
> afformentioned magic might mitigate the risk). We concluded that for
> this moment it is likely that a busy website has far more "public"
> requests to handle than edit requests and thus is it useful to have this
> more or less easy fix included in Silva now.

Indeed ;-)  Looking at the diff:
https://infrae.com/viewvc/Silva/trunk/SilvaObject.py?r1=19164&r2=19397

It seems that given REQUESTS magic, you could probably not even set 
request.model.  You also wouldn't need to explicitly delete request.model.

Cheers,
Andy



More information about the silva-dev mailing list