[silva-dev] silva-2.2: comments

Andy Altepeter aaltepet at altepeter.net
Tue Jun 9 05:02:43 CEST 2009


Hi Marc,

> > On Sunday 31 May 2009 03:55:31 pm Marc Petitmermet wrote:
> >> uploading image:
> >> why do i have to browse again for the image when i forgot to enter
> >> the
> >> required title?
> >
> > I think this is standard web behavior for file input fields.  The
> > path isn't
> > sent to the server (that's a security issue), only the contents of
> > the file.
> > So unfortunately it is impossible for Silva to re-populate the image
> > path.
>
> i have a silva code source for uploading files (original by benno) and
> there i don't have to re-enter the file again when i forget a required
> field and it is also of input type="file". so it is possible to keep
> the content of this field. the filename is read using:
>
>       filename =       getattr(file, 'filename', None)

Ah, I see what you mean now.  The rendering code for this file input field is 
deep into the z3 internals, and at this point I have to say "it would be 
nice, but I don't know where to look".
>
> >> edit link reference...:
<snip>
> > This is a good catch; thank you.  I understand what you mean about
> > editing
> > long links.  Do you think that if the link is long, the input field is
> > switched to a textarea when it has the focus?  If the textarea
> > wrapped rather
> > than added a scrollbar, it may be easier to edit long links...
>
> well, let's give it a try. this is at least better than my current
> workaround: copy the url to a text editor, fix the errors and copy it
> back to kupu...
>
> >> edit link(ed) reference...:
> >> is it possible to have the button "edit link(ed) reference..."
> >> disabled from the beginning for not valid relative silva references?
> >> currently, it gets disabled after the user has clicked on it, that's
> >> too late and useless because the next time the cursor is on the same
> >> link the button is enabled again.
> >
> > By disabled, do you mean that it would be sufficient to do nothing
> > if the
> > reference wasn't "editable"?
>
> yes. i would only change the tool tip text.
>
 I've added these two as well as allowing absolute urls for the 'edit link 
reference' feature to my Silva 2.2 todo list.  They are good ideas, but I 
need to think about how to implement them a bit.

BTW, I have added the fancy lookup/edit buttons to the image tool in the Silva 
trunk.

Regarding the ISO sorting, that's good too, but I'll let someone else from 
infrae comment on whether that change should be put into 2.2.  I'd be happy 
to do it...

Cheers,
Andy




More information about the silva-dev mailing list